WX: Comprehensive HiDPI Patch #4068

EmptyChaos · 2016-07-30T03:05:42Z

This is a comprehensive patch for DolphinWX that fixes every HiDPI problem I could find, and also fixes a few tangential segfaults and memory leaks I found along the way. It touches everything in DolphinWX so it's pretty big.

[Blue circle: high-res asset. Red circle: Upscaled low-res asset (no high-res available)]

This does not include my other PRs (#4048, #4015). It has been tested on Windows and Linux but not OS X, it should work on OS X though.

This change is

JMC47 · 2016-07-30T03:06:36Z

Well this is a pleasant surprise. I don't have a HiDPI monitor to really mess with this on though.

MayImilae · 2016-07-30T03:25:24Z

Oh, Wii banners are twice the resolution of GameCube banners, and that could be HiDPI. Looking at the image it doesn't seem like you got that... You do want to try it?

EmptyChaos · 2016-07-30T03:35:39Z

@MaJoRoesch I didn't actually know that, but fortunately I just checked and the way I wrote the code is adaptive so it already takes advantage of that fact so I don't need to change anything.

@JMC47 You can manually increase the DPI of your screen in the resolution settings on Windows if you want to mess around with it.

lioncash · 2016-07-30T03:36:46Z

Review status: 0 of 98 files reviewed at latest revision, 7 unresolved discussions.

Source/Core/DolphinWX/DolphinSlider.h, line 7 [r1] (raw file):

#pragma once

#include "wx/slider.h"

#include <wx/slider.h>

Source/Core/DolphinWX/Frame.cpp, line 479 [r1] (raw file):

  // Start debugging maximized (Must be after the window has been positioned)
  if (UseDebugger)
    this->Maximize(true);

this isn't necessary (as far as I can tell)

Source/Core/DolphinWX/Frame.h, line 122 [r1] (raw file):

  const CGameListCtrl* GetGameListCtrl() const;
  wxMenuBar* GetMenuBar() const override;
  const wxSize& GetToolbarBitmapSize() const  // Needed before the toolbar exists

The definition should be in the cpp file for consistency.

Source/Core/DolphinWX/FrameAui.cpp, line 975 [r1] (raw file):

                                         wxNO_BORDER;

  wxAuiNotebook* const nb =

You can just use auto* here, since it's obvious what the type is based on the right-hand side of the assignment.

Source/Core/DolphinWX/Main.h, line 23 [r1] (raw file):

  // Can be called from any thread
  bool IsActiveThreadsafe() const { return m_is_active_threadsafe.load(std::memory_order_relaxed); }

The definition should be in the cpp file for consistency.

Source/Core/DolphinWX/Cheats/CheatSearchTab.cpp, line 103 [r1] (raw file):

  // TODO: Implement between search
  wxArrayString filters;
  filters.Add(_("No Filter"));

The reason this was 'Unknown' was to signify an unknown initial value. Which is the same terminology Cheat Engine uses.

Source/Core/DolphinWX/Cheats/CheatSearchTab.cpp, line 303 [r1] (raw file):

  m_lview_search_results->SetItem(index, 2, buf);

  // FIXME: Is this actually useful? doubles are 64bits wide.

This isn't related to DPI changes; neither is the constexpr-ifying below. Please include these in a different PR if necessary.

Comments from Reviewable

EmptyChaos · 2016-07-30T03:59:50Z

Review status: 0 of 98 files reviewed at latest revision, 7 unresolved discussions.

Source/Core/DolphinWX/DolphinSlider.h, line 7 [r1] (raw file):