Give StringFromFormat a printf format attribute. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It gives StringFromFormat printf style arguments that should be type-checked against a format string.
|
Does that cause any additional warnings? |
|
Yep. 4 extras from what I could see make recompiling. |
|
Feel like fixing them as a followup commit in this PR? :) |
|
LGTM |
delroth
added a commit
that referenced
this pull request
Feb 6, 2014
Give StringFromFormat a printf format attribute.
orbea
pushed a commit
to orbea/dolphin
that referenced
this pull request
Aug 27, 2018
Fix compilation issue for Apple devices
JosJuice
pushed a commit
to JosJuice/dolphin
that referenced
this pull request
Aug 26, 2020
Fix netplay build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It gives StringFromFormat printf style arguments that should be type-checked against a format string.