[WIP] Jimmie Johnson viewport #4223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's fixed unless you enable Freelook. |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
Just thought I'd note that this Does NOT fix Mario Golf's inverted textures. I do believe that bug is related though, as it shares the same behavior as Jimmie Johnson in SW renderer (upside down objects do not render at all.) Then again, I could be wrong; I'm not a graphics programmer. |
|
Lint issues need to be sorted out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When the viewport height from xfmem is greater than 0, the Y axis seems to be flipped.
Tested on hardware barely, it could probably be tested more and implemented better.
This change is