Android: Update the gradle file to use android studio 2.2 cmake.

[degasus]

This change is

[degasus]

@sigmabeta May you review this PR please?

[sigmabeta]

It looks good to me. I'm gonna take a quick minute to attempt a build before I pass the review, though.

---

Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Source/Android/app/build.gradle, line 78 at r1 (raw file):

    // of product flavors are paid vs. free, ARM vs. x86, etc.
    productFlavors {
        dolphin {

If we're not actually differentiating flavors anymore, it's a good idea to do away with the entire productFlavors block.

---

Comments from Reviewable

[sigmabeta]

Review status: 0 of 12 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

Source/Android/app/build.gradle, line 68 at r1 (raw file):

        externalNativeBuild {
            cmake {
                //arguments "-DANDROID_TOOLCHAIN=gcc"

I'd either get rid of this comment or explain why it might be necessary.

---

Comments from Reviewable

[sigmabeta]

LGTM - build works, a few tiny nitpicks but otherwise this is all stuff that needs to be done.

---

Review status: 0 of 12 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

Comments from Reviewable

[sigmabeta]

Reviewed 12 of 12 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

Comments from Reviewable

[shuffle2]

is this uh, supposed to fail on the android buildslave?

[degasus]

@shuffle2 No, it's not. It needs manual interaction on the android buildbot. I'm waiting for the end of @delroth vacation.

[degasus]

This must be merged together with dolphin-emu/sadm#63

---

Review status: 6 of 14 files reviewed at latest revision, 2 unresolved discussions.

---

Source/Android/app/build.gradle, line 68 at r1 (raw file):

Previously, sigmabeta (Eder) wrote…

I'd either get rid of this comment or explain why it might be necessary.

Done.

---

Source/Android/app/build.gradle, line 78 at r1 (raw file):

Previously, sigmabeta (Eder) wrote…

If we're not actually differentiating flavors anymore, it's a good idea to do away with the entire productFlavors block.

Done.

---

Comments from Reviewable

[RisingFog]

Builds fine with Android Studio 2.2 on Windows (using assembleDebug).

[dolphin-emu-bot]

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

• rs3-bumpmapping on dx-win-nv: diff

_{^{automated-fifoci-reporter}}

[degasus]

@SeannyM @sigmabeta - This PR breaks the gamelist on mobile devices. Android TV is still fine. But I have no clue why. As you're by far more in the android UI, do you have an idea how this could broke?

[JosJuice]

To clarify, the non-TV game list now always acts as if there are no games.

[sigmabeta]

I have some time today and I can investigate why this is happening.

[degasus]

Thanks

[sigmabeta]

PR with the fix open here: #4325

(worth noting, on my phone I can't launch any games, a JNI method error occurs and I'm not quite good enough to figure that one out instantly.)

[Hydr8gon]

Something I noticed, the buildbot builds all have 5.0-995 as their build number since this was merged. I haven't compiled myself yet (just got home) but I'm assuming this is a buildbot problem.

[JosJuice]

Good catch. I've been having the same problem when compiling locally (except it was claiming to be another version than 5.0-995).