Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Wrap Vertex Array Pointer Access #4266

Closed
wants to merge 1 commit into from

Conversation

@JMC47
Copy link
Contributor

commented Sep 30, 2016

I have no idea if that's the correct description.

Not entirely sure if this is the correct behavior either, but it seems like a good idea to not allow the games to access out of range memory and crash Dolphin outright. I more or less wanted to make a Pull Request now so this issue doesn't get forgotten; since this crash has been around for many, many years.

Fixes issue 8935 and possibly other weird crashes with no explanation.


This change is Reviewable

@JMC47 JMC47 force-pushed the JMC47:starfoxassaultcrash branch from 0fb802f to f1bde54 Sep 30, 2016

@phire

This comment has been minimized.

Copy link
Member

commented Oct 1, 2016

There is a good chance this is what happens in hardware, though it's also possible it has the concept of invalid memory.

We really need to abstract this across all GetPointers, and replace the Panic Alert with a warning.

@JMC47

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2016

There are other games affected by this, but not fixed, such as MVP Baseball 2004/2005. The flickering graphics become consistently broken. This needs to be researched more.

@degasus

This comment has been minimized.

Copy link
Member

commented Oct 5, 2016

This PR is obsolet by PR #4303

@degasus degasus closed this Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.