Vulkan: Miscellaneous minor fixes #4270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stenzek
force-pushed
the
vulkan-defer-fix
branch
2 times, most recently
from
5ea6576
to
4728012
Compare
Infrequent, but still happened.
This was preventing certain settings from being updated when changed at runtime.
Should fix a possible reference to deleted framebuffers, as well as fixing the issues with the render area being correct if the game's source area changes, or auto-scaling is enabled.
Same way as GL with the dual-pass fallback. Not highly accurate, but does fix the Kirby shadow bug.
stenzek
force-pushed
the
vulkan-defer-fix
branch
from
4728012
to
28e5fa8
Compare
|
All resource handling LGTM. Reviewed 21 of 24 files at r1. Comments from Reviewable |
|
Will merge, but....really sad the new APIs are broken for me still :'( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix shutdown resource links, non-x64 build, and adds a missing call to texturecache, which meant that changing some settings in graphics options had no effect. The resource leaks are relatively minor, only happening at IR/MSAA change, but the lack of buffer execution could potentially have caused issues when settings were changed at runtime.
This change is