Remove x86_32 support from Dolphin. #428
Conversation
|
lgtm |
|
I would remove support from Common/ as well. People might use it outside our project, but maintaining x86 support is not a promise I want to make for Common/. |
|
How many x86 specific features do we have in Common, and how hard to maintain are they really? |
|
Probably some code in the x64Emitter at least. |
|
As to how hard they are to maintain: near-impossible if we can't run anything that uses them. |
|
Do we want to name things neutrally too now? Things like |
| #pragma comment(linker,"/manifestdependency:\"type='win32' name='Microsoft.Windows.Common-Controls' version='6.0.0.0' processorArchitecture='x86' publicKeyToken='6595b64144ccf1df' language='*'\"") | ||
|
|
||
| #elif defined _M_IA64 | ||
| #if defined _M_IA64 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
The Win32 target should also be removed from all vs build files. |
|
No for Jit64 because we have JitARM and JitARMIL. On Wed, May 28, 2014 at 6:52 PM, BhaaL notifications@github.com wrote:
Pierre "delroth" Bourdon delroth@gmail.com |
|
Most of the code for x86_32 support in common is in the Emitter, ABI, and CPU Detect files. |
|
Are we even considered the upstream project for the things in Common anymore? PPSSPP seems to be much more popular than we are. |
@hrydgard: ^ ? |
|
:) Dunno if there's an upstream really, more like side by side. My one objection to this is that this precludes Dolphin from supporting current 32-bit x86 Android devices, some of which may be strong enough to run at least simpler games ok. Although I have no test results to confirm that, heh, other than PPSSPP running fairly well on a weirdo x86 tablet I have. |
|
Dolphin x86 support has been decided ages ago, the discussion is mostly On Wed, Jun 4, 2014 at 1:19 AM, Henrik Rydgård notifications@github.com
Pierre "delroth" Bourdon delroth@gmail.com |
|
There aren't any x86 Android devices that support GLES3. |
|
Alright, I'll shut up then :) I wouldn't be surprised if the next round of Intel tablets do though, but hopefully they will run 64-bit Android (which I really hope makes a showing at Google I/O on Jun 25...) |
|
been a while, poke? |
|
@dolphin-emu-bot rebuild |
|
Apparently needs a rebase. |
|
My poke was with respect to also cleaning up the VS files. |
|
Rebased on latest master! |
|
@Sonicadvance1 ping |
|
Looks good to me |
Remove x86_32 support from Dolphin.
This removes all the code needed to support x86_32 in the project.
The only uses of _M_X86(outside of common) are now the parts that require it.
Common is untouched due to multiple other projects using these files and we have no reason to alienate other projects from upstreaming their changes to us.