New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mask GetPointer Differently on GameCube #4303
Conversation
| @@ -391,7 +391,10 @@ u8* GetPointer(u32 address) | |||
| { | |||
| // TODO: Should we be masking off more bits here? Can all devices access | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
That comment was what got me the idea of doing this in here; and the mask Should probably be "mask", not "wrap" tho ;) |
|
These masks should probably be derived from |
|
Right. If I could modify this to work with Metroid Prime 3's Beta, that'd be even better. Is there a way to do that? |
|
Note: Metroid Prime 3's beta doesn't run right now without modifying Dolphin, so if I can kill two birds with one stone, I definitely will. It'd make a good video. |
|
converting the enum values into variables should be possible without too much trouble, but I'd be willing to bet there will be some perf impact, since the values are used in a bunch of pretty hot code paths. Someone should try it, I guess ;) |
|
This PR is wrong, 24/32 MB is open bus. |
GameCube can't access EXRAM I'm guessing, so we need to wrap it different. Number was verified by LibOGC or something by someone who wasn't me.
Fixes Starfox Assault crash better this time.
This change is