Remove Frameskip

[Helios747]

Frameskip is really broken in Dolphin and graphics / JIT devs say fixing it would be a nightmare. So I'm removing it to protect the user. We don't even save the setting to disk anyways.

It's broken in that it's very inconsistent in what it even does to games. Sometimes it does nothing at all. Sometimes it just renders black frames in place of the frames it drops. Sometimes it entirely breaks the game. JMC says it doesn't often do what it's supposed to.

Can somebody who knows frame advance code look over this to make sure I didn't delete something important, whoever did the frame advance stuff named some functions and configmanager stuff "Frameskip" for some reason.

@degasus, please review the fifo stuff. I had no idea what I was doing.

---

This change is

[degasus]

The VideoCommon changes LGTM

---

Reviewed 18 of 18 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

Source/Core/DolphinWX/Frame.cpp, line 310 at r1 (raw file):

EVT_MENU_RANGE(IDM_SAVE_SLOT_1, IDM_SAVE_SLOT_10, CFrame::OnSaveState)
EVT_MENU_RANGE(IDM_SELECT_SLOT_1, IDM_SELECT_SLOT_10, CFrame::OnSelectSlot)
EVT_MENU_RANGE(IDM_FRAME_SKIP_0, IDM_FRAME_SKIP_9, CFrame::OnFrameSkip)

May you also drop the globals IDM_FRAME_SKIP_ ?

---

Source/Core/VideoCommon/Fifo.cpp, line 89 at r1 (raw file):

  }

  p.Do(s_skip_current_frame);

Did you increase the savestate version?

---

Source/Core/VideoCommon/Fifo.h, line 47 at r1 (raw file):

bool AtBreakpoint();
void ResetVideoBuffer();
void SetRendering(bool bEnabled);

Please also remove the header of SetRendering

---

Comments from Reviewable

[Helios747]

Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

Source/Core/DolphinWX/Frame.cpp, line 310 at r1 (raw file):

Previously, degasus (Markus Wick) wrote…

May you also drop the globals IDM_FRAME_SKIP_ ?

Done.

---

Source/Core/VideoCommon/Fifo.cpp, line 89 at r1 (raw file):

Previously, degasus (Markus Wick) wrote…

Did you increase the savestate version?

Done.

---

Source/Core/VideoCommon/Fifo.h, line 47 at r1 (raw file):

Previously, degasus (Markus Wick) wrote…

Please also remove the header of SetRendering

Done.

---

Comments from Reviewable

[dolphin-emu-bot]

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

• rs3-bumpmapping on dx-win-nv: diff

_{^{automated-fifoci-reporter}}

[degasus]

---

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[escape209]

And just like the codes that increase frame-rate, it should be possible to make frame-rate reduction codes. I made an experimental one for Burnout 2, for instance. Should be far less annoying than frame-skip and more flexible.