Add an option to kick players from netplay. #436
Merged
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| void NetPlayDiag::OnKick(wxCommandEvent&) | ||
| { | ||
| wxString selection = m_player_lbox->GetStringSelection(); | ||
| long player = 0; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
The only issue I found with this is when kicking players who occupy the same slot. However this shouldn't be happening in the first place and is irrelevant to this PR since it also happens on master. |
|
Instead of a warning you now disable the button. However it doesn't properly disable after kicking someone. You'll lose your selection but the kick button stays enabled. (Clicking it does nothing) |
| @@ -583,6 +583,18 @@ void NetPlayServer::SendToClients(sf::Packet& packet, const PlayerId skip_pid) | |||
| } | |||
| } | |||
|
|
|||
| void NetPlayServer::KickPlayer(u8 player) | |||
| { | |||
| for (auto i = m_players.begin(); i != m_players.end(); ++i) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
neobrain
added a commit
that referenced
this pull request
Jun 19, 2014
Add an option to kick players from netplay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.