Lighting cleanup

[degasus]

This branch cleans up our lighting code:

• ppl doesn't require to upload the consts twice
• also for shaderManagers
• use structs for lighting constants

[degasus]

Anything else to fix? I'd like to see this merged soon to port PR #394 to normalize on the CPU.

[galop1n]

It is not possible to normalise on cpu, it is done this way so an other
channel can use the light as a non directional diffuse too.
On Jun 5, 2014 8:02 AM, "Markus Wick" notifications@github.com wrote:

Anything else to fix? I'd like to see this merged soon to port PR #394
#394 to normalize on the CPU.

—
Reply to this email directly or view it on GitHub
#439 (comment).

[degasus]

You have normalized all accesses of this constant. So which other channel are you refering to?

[galop1n]

Oh was thinking about the light pos params that can be used as a position
AND a direction in the same shader. Not fully awake sorry
On Jun 5, 2014 9:45 AM, "Markus Wick" notifications@github.com wrote:

You have normalized all accesses of this constant. So which other channel
are you refering to?

—
Reply to this email directly or view it on GitHub
#439 (comment).

[degasus]

That's why I want this PR to get merged before this to be done on the CPU. It will be less confusing as this parameters are splitted into a struct :)

[neobrain]

LGTM once the fixes are squashed into the previous commits.

[degasus]

@dolphin-emu-bot rebuild

[neobrain]

@dolphin-emu-bot rebuild

[neobrain]

Looks like build went well, even though there's not definite "okay" from the buildbot ...