Revert "DSound: use DSound notifications to produce sound." #440
+11
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4990b89. The commit is causing substantial performance issues for the DSound backend which I somehow didn't catch during testing.
|
Any point to keeping dsound support? Why not just drop it? |
|
We could just drop it... the only issue I can think of is that installing the June 2010 DirectX SDK headers is a bit of a pain. |
|
Yea, fuck installing the old SDK. |
|
I suppose until we get a decision on the DSound removal done, we can merge this one. Sounds good? @dolphin-emu-bot rebuild |
|
Yes, sounds good. |
neobrain
added a commit
that referenced
this pull request
Jun 13, 2014
Revert "DSound: use DSound notifications to produce sound."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This reverts commit 4990b89.
The commit is causing substantial performance issues for the DSound backend which I somehow didn't catch during testing. (By performance here, I mean CPU usage.)