Loadstore cleanup #443
Merged
Loadstore cleanup #443
+85
−393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Less code is good, and this should make future changes to memory handling easier.
I'm planning on making changes to the memory code, so I don't want this stuff to get in the way. The slight performance hit to JITIL isn't really important at the moment.
|
I'm not seeing any issues with the code. |
|
I ran through about a dozen games with this to see if anything obvious was broken. There isn't. No real performance change either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Misc changes to simplify load/store code, and to more uniformly use safe loads and stores. The changes are pretty much all independent of each other except the change to SafeLoadToReg to support 64-bit loads.