Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video backends: remove dead code. #445

Merged
merged 1 commit into from Jun 13, 2014

Conversation

magumagu
Copy link
Contributor

@magumagu magumagu commented Jun 1, 2014

Should all be obvious.

@degasus
Copy link
Member

degasus commented Jun 1, 2014

I think we shouldn't remove this code just because it's dead. We don't sync the gpu at all atm, but we'll have to. So in which way do we want to do this? As the removed is known to work a bit, it's maybe a useful reference.

@magumagu
Copy link
Contributor Author

magumagu commented Jun 1, 2014

What bit in particular are you referring to as "known to work a bit"?

@neobrain
Copy link
Member

@degasus Ping, please reply to @magumagu's question.

I think removing this dead code is useful indeed. Regardless whether it worked or just a bit or not at all, it seemed like it wasn't particularly sophisticated anyway. If anyone were interested in implementing the functionality properly, I think this code would be more confusing (potentially giving wrong clues as to how a proper implementation looks like) than actually helping.

LGTM hence.

@dolphin-emu-bot rebuild

@degasus
Copy link
Member

degasus commented Jun 13, 2014

Indeed, this code is likely wrong. so LGTM

neobrain added a commit that referenced this pull request Jun 13, 2014
Video backends: remove dead code.
@neobrain neobrain merged commit d7736ac into dolphin-emu:master Jun 13, 2014
@magumagu magumagu deleted the video-dead-code branch June 14, 2014 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants