Expand GetBPRegInfo to include the rest of the BP registers. #448
+475
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UT_4). Also fixed the alignment of the register values.
|
There's not much point in this since the fifoplayer analyzer is sort of obsoleted by hwfifoplayer's dffclient, but other than that LGTM. |
neobrain
added a commit
that referenced
this pull request
Jun 5, 2014
Expand GetBPRegInfo to include the rest of the BP registers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Descriptions are not done. I do not know enough about all the BP registers to accurately make descriptions for all of them. However, now most (if not all) BP registers in the FIFO analyzer should actually have the correct names now, rather than being
UNKNOWN_[command number].