New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCC build issue with Fedora (linux) #4496
Conversation
|
Our convention for Dolphin is to use uppercase for constants even if they aren't defines. Could you change the names to something else? Maybe CHARACTER instead of CHAR? |
|
And I believe those can be made |
|
Done, see new commit |
|
The lint bot (running clang-format) is failing, so you'll need to format the lines the way it shows. (The max length for a line is 100 characters.) |
Fixes build issue with GCC/CPP 6.2.1 build issues on Fedora 26
|
Gotcha, I've made the style fixes and squashed the commits |
|
Thanks @Mystro256 |
|
Thank you @Mystro256, as both a Fedora and Dolphin user this means a lot. |
|
No problem, I maintain the official fedora dolphin package for a reason: |
Building dolphin with Fedora 26 (in development) seems to cause the following error:
I assume this is because CHAR_WIDTH already exists as a "#define" somewhere.
Making it lowercase fixes the issue. I also changed the rest of the const's to lowercase for consistency.
EDIT: I've reworked it so CHAR_ is replaced by CHARACTER_ so style can be preserved. see below.