Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video statistics update #452

Merged
merged 2 commits into from Jun 29, 2014
Merged

Video statistics update #452

merged 2 commits into from Jun 29, 2014

Conversation

degasus
Copy link
Member

@degasus degasus commented Jun 2, 2014

Some of them aren't used any more, and lots of alignment

@lioncash
Copy link
Member

lioncash commented Jun 2, 2014

<3 for vertical alignment. I should have done that when I initially did the 'stringification' of the stats.

@magumagu
Copy link
Contributor

magumagu commented Jun 2, 2014

LGTM.

@degasus
Copy link
Member Author

degasus commented Jun 5, 2014

imo ready for merging ;)

str += StringFromFormat("vshaders alive: %6i\n", stats.numVertexShadersAlive);
str += StringFromFormat("shaders changes: %6i\n", stats.thisFrame.numShaderChanges);
str += StringFromFormat("dlists called: %6i\n", stats.thisFrame.numDListsCalled);
str += StringFromFormat("Primitive joins: %6i\n", stats.thisFrame.numPrimitiveJoins);

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@neobrain
Copy link
Member

Bump. People haven't replied when I said "feel free to overvote me", nor did the alignment changes get reverted.

@degasus Are you going to do anything about this?

@delroth
Copy link
Member

delroth commented Jun 22, 2014

+1 for alignment changes.

@degasus
Copy link
Member Author

degasus commented Jun 22, 2014

@neobrain I think this is 1:1. We both are waiting to get overvoted :/

@degasus
Copy link
Member Author

degasus commented Jun 27, 2014

iirc JMC47 also thinks it's worse, so we're on par again. However, I've removed the alignment :(

lioncash added a commit that referenced this pull request Jun 29, 2014
Video statistics update
@lioncash lioncash merged commit d720e3e into dolphin-emu:master Jun 29, 2014
@degasus degasus deleted the stats branch July 12, 2014 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants