Common: Move BreakPoints into Core #4543

Merged
merged 1 commit into from Jan 10, 2017

Projects

None yet

3 participants

@lioncash
Member

BreakPoints utilizes the jit global variable, so this was making Core and Common cyclical dependencies on one another.

@Parlane
Member
Parlane commented Jan 8, 2017

LGTM

@degasus
Member
degasus commented Jan 10, 2017

This PR makes sense, no clue why it isn't merged already. Now it needs a rebase :/

@lioncash lioncash Common: Move BreakPoints into Core
BreakPoints utilizes the jit global variable, so this was making Core and
Common cyclical dependencies on one another.
ea8fc59
@Parlane Parlane merged commit a807db1 into dolphin-emu:master Jan 10, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd Build succeeded on builder pr-freebsd
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@lioncash lioncash deleted the lioncash:cycles branch Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment