Stringify ArmCPUDetect.cpp. #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a CPU string was incapable of being found we would return a null pointer, which would crash with strncpy. Also if we couldn't get a CPU implementer we would call free() to a null pointer. In addition, detect 64bit ARM running.
|
Works Flawlessly. |
| char *cpu_string = nullptr; | ||
| const std::string marker = "Hardware\t: "; | ||
| std::string cpu_string = "Unknown"; | ||
|
|
||
| // Count the number of processor lines in /proc/cpuinfo |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sonicadvance1
added a commit
that referenced
this pull request
Jun 3, 2014
Stringify ArmCPUDetect.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Obsoletes PR #447
@delroth There we go :)
@Sonicadvance1 Would you want to test it on Android to make sure everything still checks out? It should, but I'd rather have the word of the person who works on ARM the most :P