x64Emitter: J_CC: use 32 bit offset automatically #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
imo this flag should stay for backpatching, but it should automaticly fall back to the 5 byte version for large jumps. |
|
That's what this does. J_CC is overloaded. |
|
Maybe the overloaded versions of J_CC should be renamed to Jcc_forwards and Jcc_backwards? |
|
+1 for that change, I have no idea why we never did this back then (but stuck with the force5bytes parameter). |
|
I believe this is ready to be merged. |
|
LGTM as it is |
Sonicadvance1
added a commit
that referenced
this pull request
Jun 7, 2014
x64Emitter: J_CC: use 32 bit offset automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When the offset is known, there is no need to force an additional argument.