Attempt re-adding the missing AXWii DSP_SYNC #4571

Merged
merged 2 commits into from Jan 10, 2017

Projects

None yet

5 participants

@degasus
Member
degasus commented Dec 27, 2016

Rebase of PR #3756

delroth added some commits Mar 29, 2016
@delroth @degasus delroth ax: switch to new style interrupt triggering 7c4bbcf
@delroth @degasus delroth axwii: re-add the missing sync -- might work better with the new Mail…
…Handler implementation
6b65344
@iwubcode

While the code change seems fairly trivial and I can understand what it's doing at some level, I can't offer any suggestions. However, I'm happy to do some testing. Is there any specific game / scenario I should be looking at?

@delroth
Member
delroth commented Jan 6, 2017

LGTM if @JMC47 doesn't notice anything breaking with AX Wii games.

@iwubcode
iwubcode commented Jan 6, 2017

@delroth - out of curiosity, what are "AX" Wii games? Sorry I know little about this stuff..

@JosJuice
Contributor
JosJuice commented Jan 6, 2017

@iwubcode AX is the most common series of DSP ucode. There is also a series that we call Zelda ucode.

@JMC47
Contributor
JMC47 commented Jan 10, 2017

As it was last time, I still can't find any bugs with this. Ran a bunch of Wiiware and a few super popular titles.

@degasus degasus merged commit d9a37d3 into dolphin-emu:master Jan 10, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd Build succeeded on builder pr-freebsd
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment