Fix a typo in a function prototype in PowerPCDisasm.h #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be GetGPRName not GetGRPName. Removed an unnecessary extern declaration of GetGRPName in RegisterWindow.cpp. Also added GetFPRName to the PowerPCDisasm header for consistency.
|
At this point I'm really not sure why Bochs_disasm is in Externals. Anyone opposed to moving it to Common/? |
|
Why was it referenced in RegisterWindow.cpp anyways? It wasn't used there as far as I can see... |
|
Moving Bochs disassembler SGTM. |
delroth
added a commit
that referenced
this pull request
Jun 8, 2014
Fix a typo in a function prototype in PowerPCDisasm.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Should have been GetGPRName, not GetGRPName.
Also added GetFPRName to the PowerPCDisasm header for consistency.
Yes this modifies an external, however PowerPCDisasm isn't actually a part of Bochs. It's just grouped in with it.