New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVIDump: Updates to avoid deprecation warnings #4596
Conversation
I'm not sure what's going on with FifoCI. Some differences look like the underlying picture is slightly different, while others have graphical issues that seem unrelated to anything FFmpeg would incur. Some fifologs failed on current master but succeed on this PR. I'm not very good with FifoCI, anyone have any idea what's causing this? |
612283c
to
ff10100
Compare
Boom, majority of FifoCI errors have been fixed ( Remaining errors look like compression artifacts (and don't occur on ogl-lin-mesa, which uses FFV1). The specific change that causes this is using |
9c7001d
to
46d6fb7
Compare
@dolphin-emu-bot rebuild |
Just for reference, before the previous synchronization, FifoCI results were:
|
LGTM. |
7960a70
to
316a18e
Compare
For reference, before the previous synchronization, there were no FifoCI discrepancies. |
This function frees all associated streams and codec contexts, and has existed since libavformat 52.96.0 (February 2011).
Minor oversight in the existing code.
Using the AVCodecContext contained in AVStream for muxing is officially discouraged[1] and AVStream::codec was deprecated in favor of AVStream::codecpar in libavformat 57.33.100 / 57.5.0. 1: [FFmpeg-cvslog] lavf: replace AVStream.codec with AVStream.codecpar: https://ffmpeg.org/pipermail/ffmpeg-cvslog/2016-April/099152.html
For reference, before the last synchronization, there were no FifoCI discrepancies. |
On current master, compiling with FFmpeg 3.2.1 on macOS results in a lot of warnings like:
This commit batch fixes the warnings, and should still be compatible with older versions of FFmpeg.