HotkeyInputConfigDialog: Move UI creation into named functions #4617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor shouldn't be used as a dumping ground for all UI-related initialization. Doing so makes it somewhat more difficult to reason about how certain UI elements get created. It also puts unrelated identifiers in the same scope. This separates the UI creation out so code relevant to each component is self-contained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor shouldn't be used as a dumping ground for all UI-related initialization. Doing so makes it somewhat more difficult to reason about how certain UI elements get created. It also puts unrelated identifiers in the same scope.
This separates the UI creation out so code relevant to each component is self-contained.