JitCache: Get rid of reliance on the JIT global variable #4637

Merged
merged 5 commits into from Jan 9, 2017

Projects

None yet

2 participants

@lioncash
Member
lioncash commented Jan 9, 2017

Includes some preliminary cleanup beforehand.

This also has the benefit of getting rid of a silly inheritance tree segment where the cached interpreter itself was acting like the block cache, even though using composition worked just as fine (and better). Doing so also eliminates non-virtual function shadowing between CachedInterpreter and JitBaseBlockCache, where Init and Shutdown functions from JitBaseBlockCache would be shadowed.

lioncash added some commits Jan 9, 2017
@lioncash lioncash JitCache: Move private class details below public details
Also organizes cpp file organization to match the function layout.
cf18aeb
@lioncash lioncash JitCache: Move implementation details into the cpp file 2b8ede8
@lioncash lioncash CachedInterpreter: Move to its own directory eddccb3
@lioncash lioncash CachedInterpreter: Separate the block cache from CachedInterpreter
An interpreter is not a block cache. It may utilize a block cache, it may
contain a block cache but it *is not* A block cache.
f75aab1
@lioncash lioncash JitCache: Get rid of reliance on the JIT global variable
37d1006
@degasus
Member
degasus commented Jan 9, 2017

LGTM, but I'd like to get this two calls out of the JitCache at all. Having some flags cached by the Jit itself but cleared by the JitCache called by the Jit sounds a bit bad.

@degasus degasus merged commit 440a2f8 into dolphin-emu:master Jan 9, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd Build succeeded on builder pr-freebsd
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@lioncash lioncash deleted the lioncash:jitcache branch Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment