Use std::string in LogContainer's constructor. #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
| : m_enable(enable) | ||
| LogContainer::LogContainer(const std::string& shortName, const std::string& fullName, bool enable) | ||
| : m_fullName(fullName), | ||
| m_shortName(shortName), |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This allows for removal of the strcpy calls, also it's technically way more safe, though I doubt we'll ever have a log name larger than 128 characters or a short description larger than 32 characters. Also moved these assignments into the constructor's initializer list.
|
@delroth Fixed the alignments. |
delroth
added a commit
that referenced
this pull request
Jun 5, 2014
Use std::string in LogContainer's constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This allows for removal of the strcpy calls, also it's technically way more safe, though I doubt we'll ever have a log name larger than 128 characters or a short description larger than 32 characters. Moved these assignments into the constructor's initializer list.
Also changed the file logger to take a string instead of const char*. Kills off a c_str call.