Android: Change Exit Without Saving to Save and Exit #4643

Merged
merged 1 commit into from Jan 11, 2017

Projects

None yet

3 participants

@SeannyM
Member
SeannyM commented Jan 10, 2017 edited

This saves us from having to press the back button multiple times to get back to the game list from the settings. More importantly, it will help all the users who are pressing the 'X' button to leave settings, and then wondering why their settings aren't being saved.

@JosJuice
Contributor

Yes please. Just having an X button there that didn't save was very non-intuitive.

In the long term, do we want to have a quit without saving button at all? I don't think it's typical for settings in Android apps, and we don't have any button like that in DolphinWX.

@SeannyM
Member
SeannyM commented Jan 10, 2017 edited

@JosJuice I agree, I don't see much point in having it either. I considered removing it for this PR, but I didn't add it in the first place, so I wasn't sure if anyone still wanted it. If nobody has any objections, I'll remove it.

@SeannyM SeannyM Android: Change Exit Without Saving to Save and Exit
cc29691
@SeannyM SeannyM changed the title from Android: Add a Save and Exit button for settings to Android: Change Exit Without Saving to Save and Exit Jan 10, 2017
@Parlane
Member
Parlane commented Jan 10, 2017

LGTM

@Parlane Parlane merged commit a3bef10 into dolphin-emu:master Jan 11, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd Build succeeded on builder pr-freebsd
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@SeannyM SeannyM deleted the SeannyM:settings-saving branch Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment