IOS HLE: Make Device::Update() return void #4644

Merged
merged 2 commits into from Jan 11, 2017

Projects

None yet

2 participants

@leoetlino
Member

The return value is not used at all, so it's useless to keep it. And its semantics were not even well defined.

While I was removing unused Update()s, I have also removed some useless overrides in the BT device classes (command handlers which are never used).

leoetlino added some commits Jan 11, 2017
@leoetlino leoetlino IOS HLE: Make Device::Update() return void
The return value is not used at all, so it's useless to keep it.
And the semantics of the return value were not even well defined.
f66aab6
@leoetlino leoetlino IOS HLE: Remove useless overrides in bt_stub
Since the Open command won't ever return with the stub, there's no way
we will get a Close/IOCtl/IOCtlV for it, so we don't have to
implement it at all.
15567ef
@degasus degasus merged commit f82d6c6 into dolphin-emu:master Jan 11, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd Build succeeded on builder pr-freebsd
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@leoetlino leoetlino deleted the leoetlino:no-return-value branch Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment