Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow progressive scan to be set by game ini. #466

Merged
merged 1 commit into from Jun 22, 2014

Conversation

RachelBryk
Copy link
Member

No description provided.

@lioncash
Copy link
Member

lioncash commented Jun 6, 2014

Looks fine to me. Can I just ask why though? (dunno if any discussion related to this was done on the IRC)

@Linktothepast
Copy link
Contributor

Ι asked rachel about it. There are a lot of virtual console games that need the option and i intent to add them in the gameini database.

@lioncash
Copy link
Member

lioncash commented Jun 6, 2014

Ah OK, didn't know that.

@magumagu
Copy link
Contributor

magumagu commented Jun 6, 2014

For reference, this is http://code.google.com/p/dolphin-emu/issues/detail?id=6466.

Not sure what to think about this; I mean, having a gameini option seems fine, but someone should probably actually look at issue 6466 before we add this as a hack in the default gameini for a bunch of games.

@RachelBryk
Copy link
Member Author

That's not really relevant to this PR though. ALL options should be possible to set via game ini, otherwise users are forced to do stupid things like create multiple copies of dolphin in order to set different settings for different games. I wrote this because it was brought to my attention that it was it wasn't possible to set via game ini. Even if there were no games that required the setting, i think that's a good enough reason.

@magumagu
Copy link
Contributor

magumagu commented Jun 7, 2014

Okay.

@Linktothepast Linktothepast mentioned this pull request Jun 10, 2014
@delroth
Copy link
Member

delroth commented Jun 22, 2014

Please rebase.

delroth added a commit that referenced this pull request Jun 22, 2014
Allow progressive scan to be set by game ini.
@delroth delroth merged commit 47c2d0d into dolphin-emu:master Jun 22, 2014
@RachelBryk RachelBryk deleted the progressive-game-ini branch July 6, 2014 06:16
MikeRavenelle pushed a commit to MikeRavenelle/dolphin that referenced this pull request Sep 2, 2014
Update that adds NES and SNES (U) Virtual Console games to the database.

Fixes issue 7349 (More Aggressive Twilight Princess Hack), issue 7337
(Def Jam Vendetta No Cutscenes?) and issue 7258 (Madden NFL 2003
requires RealXFB for videos).
Workaround for issue 7322 (Slow audio ingame in various gamecube games
when using HLE, LLE audio works fine.) by enforcing LLE audio for the
affected games for the time being.

This PR depends upon pr dolphin-emu#466 "Allow progressive scan to be set by game
ini".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants