Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove function StringFromInt from StringUtil.cpp/.h. C++11 has std::to_string for this now. #47

Merged
merged 1 commit into from Feb 6, 2014

Conversation

lioncash
Copy link
Member

@lioncash lioncash commented Feb 6, 2014

No description provided.

@Sonicadvance1
Copy link
Contributor

I like that we use that function in one place.
LGTM

delroth added a commit that referenced this pull request Feb 6, 2014
Remove function StringFromInt from StringUtil.cpp/.h. C++11 has std::to_string for this now.
@delroth delroth merged commit 12d026c into dolphin-emu:master Feb 6, 2014
@lioncash lioncash deleted the remove-stringfromint branch February 6, 2014 23:19
delroth added a commit that referenced this pull request Feb 6, 2014
Breaks Android build.

This reverts commit 12d026c, reversing
changes made to 6d67849.
@delroth
Copy link
Member

delroth commented Feb 6, 2014

Breaks Android build. Reopening.

leoetlino added a commit to leoetlino/dolphin that referenced this pull request Jul 5, 2017
Updated version of dolphin-emu#47. Android should support to_string now that
we use a modern version of libc++ when building.
Techjar pushed a commit to Techjar/dolphin that referenced this pull request Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants