Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JitArm64: Initial implementation of the BLR optimization. #4796

Merged
merged 1 commit into from Feb 2, 2017

Conversation

degasus
Copy link
Member

@degasus degasus commented Feb 1, 2017

This PR lacks the guard page to catch stack overflows. Else it seems to be fully functional. There haven'T been much performance optimizations, this PR tries to upload readable code. Still much faster than master.

SUB(SP, X0, 16);
}

void JitArm64::WriteLKExit(u32 destination, u32 after)

This comment was marked as off-topic.


if (inst.LK_3)
{
WriteLKExit(WA, js.compilerPC + 4);

This comment was marked as off-topic.

@degasus degasus merged commit 318a387 into dolphin-emu:master Feb 2, 2017
@eddiebrook
Copy link

some games crash in game after few seconds of gameplay. the only way to fix this is disabling multicore.

for example dbz tenkiachi 3 wii

@degasus
Copy link
Member Author

degasus commented Feb 2, 2017

@eddiebrook Just to be sure, you haven't disabled "SyncOnSkipIdle" in the Dolphin.ini, have you?

It's quite likely that I've broken something here, but I doubt single core may fix it.

@eddiebrook
Copy link

No
i have SyncOnSkipIdle = True

@eddiebrook
Copy link

for example in the game related before.

1 i need to quicksave before enter to fight (or crash)
2 back to dolphin menú and disable multicore
3 quickload the game again, enter in battle (no crash)
4 quicksave again and back to dolphin menú
5 enabled dualcore again and quickload the game
6 the game work fine until enter to another scenario/fight

@degasus
Copy link
Member Author

degasus commented Feb 2, 2017

May you try if booting in single core also crashes? Loading and storing a savestate touches the JIT state, so it might be savestate related instead of dual core.

@brujo5
Copy link

brujo5 commented Feb 2, 2017

I tried that to and working fine in single core. (Loaded Normal save)

And you @eddiebrook

@degasus
Copy link
Member Author

degasus commented Feb 28, 2017

@eddiebrook PR #4983 fixes a random crash which sounds like the one you're reporting here. Does this PR fixes the regressions of this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants