BitField fixes #483
Merged
BitField fixes #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value. Sometimes (in particular when using non-typesafe functions) it can be convenient to have a getter method rather than performing a potentially lengthy explicit cast.
|
Looks good! |
neobrain
added a commit
to neobrain/citra
that referenced
this pull request
Jul 16, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixing* a fairly dangerous API oddity pointed out by @kayru, as well as some warnings (of which I'm not sure if they were new or only introduced by the previous fix), and added a small getter value for convenience (.. not really useful for anything Dolphin does currently, but it has proven to be very useful for Citra).
(*) "Fixing" = abuse gcc and clang to error out compilation if a copy assignment operator is used with BitField, because MSVC doesn't support unrestricted unions, which are necessary to implement sane copy assignment.