JitArm64: Use a custom stack with proper guard pages. #4870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Feb 8, 2017
| @@ -28,14 +28,24 @@ void JitArm64::GenerateAsm() | |||
|
|
|||
| MOVP2R(PPC_REG, &PowerPC::ppcState); | |||
|
|
|||
| // Store the stack pointer, so we can reset it if the BLR optimization fails. | |||
| // Swap the stack pointer, so we have propper guard pages. | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
degasus
changed the title
|
crash still happend, just take a bit more time until crash appear again. happend with wii games and multicore option enabled. |
|
@brujo5 Oh, so this PR have an effect at all? I wonder if this PR is just broken, but delay the crash because of a bigger stack. Is there anything interesting in the logs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This hopefully fixes the regressions of PR #4796 .