Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tidy up of sprintf to StringFromFormat #49

Merged
merged 1 commit into from Feb 8, 2014
Merged

Some tidy up of sprintf to StringFromFormat #49

merged 1 commit into from Feb 8, 2014
+64 −111

Conversation

Parlane
Copy link
Member

@Parlane Parlane commented Feb 8, 2014

No description provided.

delroth
delroth reviewed Feb 8, 2014
View reviewed changes
Source/Core/Common/CDUtils.cpp
@@ -225,14 +219,12 @@ bool cdio_is_cdrom(std::string device)
bool res = false;

This comment was marked as off-topic.

Sign in to view

@delroth
Copy link
Member

delroth commented Feb 8, 2014

LGTM

Parlane added a commit that referenced this pull request Feb 8, 2014
@Parlane
Merge pull request #49 from Parlane/sprintf_tidy
2875543 
Some tidy up of sprintf to StringFromFormat
@Parlane Parlane merged commit 2875543 into dolphin-emu:master Feb 8, 2014
delroth added a commit that referenced this pull request Feb 9, 2014
@delroth
Revert "Merge pull request #49 from Parlane/sprintf_tidy"
e59f770 
Change broke the build on Debian stable.

This reverts commit 2875543, reversing
changes made to 64e01ec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@Parlane @delroth