IOS: Separate net/kd code out from Net.cpp #4900

Merged
merged 1 commit into from Feb 15, 2017

Projects

None yet

3 participants

@lioncash
Member

Net.cpp is just a huge glob of network related things, this separates the KD portion out to make things a little more manageable. The others classes should be split up, however they share a common dependency on an internal function (GetMacAddress) which can be addressed in a follow up. This moves the 'easy' stuff first to slice off a sizeable portion that would need to be read if I combined both changes.

@lioncash lioncash IOS: Separate net/kd code out from Net.cpp
Net.cpp is just a huge glob of network related things, this separates the
KD portion out to make things a little more manageable.
40cea77
@leoetlino

LGTM

@sepalani

Otherwise, seems fine to me.

+
+u8 NetKDRequest::GetAreaCode(const std::string& area) const
+{
+ static std::map<const std::string, u8> regions = {
@sepalani
sepalani Feb 12, 2017 Contributor

Do you plan to static const this map in another PR?

@lioncash
lioncash Feb 12, 2017 Member

Sure, I can do that in a different PR. This PR is just intended to move code with no differing functional changes.

+
+u8 NetKDRequest::GetHardwareModel(const std::string& model) const
+{
+ static std::map<const std::string, u8> models = {
@sepalani
sepalani Feb 12, 2017 Contributor

Ditto.

@lioncash lioncash merged commit 28a6575 into dolphin-emu:master Feb 15, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@lioncash lioncash deleted the lioncash:netkd branch Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment