Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EmuWindow #492

Merged
merged 1 commit into from Jun 15, 2014
Merged

Remove EmuWindow #492

merged 1 commit into from Jun 15, 2014

Conversation

CrossVR
Copy link
Contributor

@CrossVR CrossVR commented Jun 14, 2014

I couldn't find any useful purpose for this class, removing it doesn't seem to break anything.

The most important change to review in this PR is how the window handle is passed around between classes, particularly this instance.

This change has been done in preparation of exclusive fullscreen support, but makes sense on its own hence the PR.

All it did was raise complexity.
@delroth
Copy link
Member

delroth commented Jun 14, 2014

@dolphin-emu-bot rebuild

Might be worth looking who introduced this and asking him why?

@CrossVR
Copy link
Contributor Author

CrossVR commented Jun 14, 2014

A git blame just turns up the initial commit, it looks like it's just pure legacy code.

@delroth
Copy link
Member

delroth commented Jun 14, 2014

Paging @hrydgard for history lessons :p

@CrossVR
Copy link
Contributor Author

CrossVR commented Jun 15, 2014

I forgot to mention in the PR description, this commit removes the code that waits until a window resize is done before resizing the backbuffer. Instead it will now resize the buffers as soon as it's done presenting a frame. In testing this did not result in any issues and it simplifies the code significantly.

However, if it causes any issues I can look into re-implementing that feature.

@hrydgard
Copy link
Contributor

@delroth , lol, you haven't killed this until now? :)

delroth added a commit that referenced this pull request Jun 15, 2014
@delroth delroth merged commit 020b4fd into dolphin-emu:master Jun 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants