Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Fix GPU hangs on AMD Polaris #4924

Merged
merged 4 commits into from Feb 18, 2017

Conversation

@stenzek
Copy link
Contributor

@stenzek stenzek commented Feb 18, 2017

It appears that our usage of primitive restart is causing issues on AMD hardware, I'm guessing maybe due to the combination of base vertex plus primitive restart.

This PR disables primitive restart on AMD drivers (it might be okay on radv though, so we probably need a way to differentiate these two drivers).

Thanks to @iwubcode for painfully testing silly ideas for this bug.

@iwubcode
Copy link
Contributor

@iwubcode iwubcode commented Feb 18, 2017

This fixes the issue I raised: 9879.

It works flawlessly!

@stenzek stenzek force-pushed the stenzek:vulkan-list-restart branch from 258fbce to e2ddb38 Feb 18, 2017
@stenzek stenzek merged commit b8eb108 into dolphin-emu:master Feb 18, 2017
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@stenzek stenzek deleted the stenzek:vulkan-list-restart branch Jun 13, 2017
@kode54
Copy link

@kode54 kode54 commented Aug 3, 2018

I just experienced this issue with Super Mario Sunshine, running Vulkan on an RX480, using AMD's 18.7.1 drivers, and Dolphin 5.0-8512. The issue occurred shortly after I skipped the demo loop cut scene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.