Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set DAZ on x86 in non-IEEE mode. #498

Merged
merged 2 commits into from Jun 19, 2014

Conversation

magumagu
Copy link
Contributor

I have no idea why we were using it in the first place; it doesn't match the behavior of PPC NI flag.

I have no idea why we were using it in the first place; it doesn't match
the behavior of PPC NI flag.
@delroth
Copy link
Member

delroth commented Jun 15, 2014

@dolphin-emu-bot rebuild

Build failed on Android, not sure why it's shown as success :-/

@Tilka
Copy link
Member

Tilka commented Jun 16, 2014

To summarize the discussion on IRC: The Broadway spec says non-IEEE flushes both operands and results so in theory we would need DAZ and FTZ on x86. However, it also says that you can't use double-precision operands with single instructions which is what some games seem to be doing. So if disabling DAZ helps to emulate whatever the Broadway is actually doing I'd say go for it (as long as it doesn't break anything well-defined but so far that doesn't seem to be the case, @magumagu?).

@magumagu
Copy link
Contributor Author

Disabling DAZ definitely gets us closer to doing the right thing, and it shouldn't break anything.

@neobrain
Copy link
Member

Welp, let's cross some fingers that you're right.. :p

neobrain added a commit that referenced this pull request Jun 19, 2014
Don't set DAZ on x86 in non-IEEE mode.
@neobrain neobrain merged commit 0e0238e into dolphin-emu:master Jun 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants