ES_LAUNCH fixes for disk channel etc

[magumagu]

A few small changes to get ES_LAUNCH working for targets that aren't channels. Also gets rid of the old DOL-loader HLE.

As far as I know, this fixes the Disk Channel and Metroid Prime Trilogy MP2 multiplayer; not sure what else, if anything, is affected.

[JMC47]

It affects Metroid Prime Trilogy single player as well, makes it load the proper difficulties and allow you to finally have multiple save files. House of the Dead 2/3 also needs this for loading the other game (I forgot which one)

One quirk of the system menu, which has been carried over from when it worked last time around 3.5 is that the initial game you boot is the one that gets assigned the savestate/screenshots, rather than the current game/channel. If I start up MegaMan 9, boot to system menu, load a disc, and play MKWii, then feel the need to savestate, well, that savestate is assigned to MegaMan 9!

I don't know if that's fixable, or if it even makes sense to change for savestates, but it sure is weird.

It should be noted that GameCube games because properly implementing it would be a pita for all intents and purposes. Maybe some kind of hotfix could be made eventually, but I don't think it's the job of this PR.

I've been playing around with this for a while and have run into absolutely no regressions running games from the gamelist, for all I know it doesn't affect them at all. All my Wii games run properly from the disc channel, screenshots and savestates do work with the above mentioned quirk.

[Parlane]

I approve!

[MayImilae]

-Metroid fanboy dance-

[magumagu]

There's all sorts of different things we could do with the ability to launch games/channels/etc from the system menu, but it gets complicated quickly, especially given that we have to deal with gameini files.

[Parlane]

Can you launch Opera again from the sys menu ?

[JMC47]

Yes, and load up dolphin-emu.org, then download dolphin in dolphin.

[Linktothepast]

Does it fix https://wiki.dolphin-emu.org/index.php?title=RSBE01 masterpieces? Btw are there automated builds for pr's to test?

[Linktothepast]

Ok found builds and found out that mater pieces now launch and end in an instant (they are time limited demos, probably has something to do with that).

[delroth]

@Linktothepast for future reference, since very recently we upload builds of all PRs to https://dl.dolphin-emu.org/prs/

[Linktothepast]

Also a regression, in Kirby's Dream Collection when you launch a classic title controls change to gamecube controller no matter what (even if you have it disabled). Problem is that you can't access the home menu and try to exit the classic game that way.

[JMC47]

@Linktothepast - There was another modification that fixed the Brawl Masterpieces. They're literally not getting loaded right now because they're on partitions of the DVD that dolphin isn't reading. I'm certain it'll get added soon.

[magumagu]

There's an extra change required to fix the Brawl masterpieces; it's in unrelated code, so I plan to submit it separately. See magumagu/dolphin@ipchle-disk-channel...dvd-low-open-partition .

No clue about Kirby's Dream Collection... can someone narrow it down to which commit causes the regression?

[JMC47]

@Linktothepast this may not be a glitch. Have you tried pressing alt f5 after the game loads? It could just be the Wiimote getting disconnected, and Dolphin's auto-reconnect on emulated wiimotes. Even on a real wiimote, still try it.

[JMC47]

I tested this behavior in other games and found it to be correct to the Wii. in Super Smash Bros. Brawl, when launching masterpieces, the Wiimote is no longer connected afterwards! So, hitting alt f5 fixes this if you're using an emulated wiimote. On Real wiimotes, just hitting the wiimote buttons, just like on real Wii.

I don't have Kirby Dream Collection, but I'm guessing it's the same there.

@magumagu if this behavior is correct, are there any other blocking issues on this?

[Linktothepast]

Yep, you are correct that it disconnects, and seems to be working fine afterwards, returning back to the menu making the game perfectly playable now. And i haven't tested with a real wiimote, but if you are saying it's the correct behavior to be disconnected i have no reason to argue, LGTM too.

[JMC47]

I don't know for that particular game, but I'm guessing it's the same as all the other games. This LGTM, I retested everything while looking at that possible regression. Would like to see this merged in for the progress report if possible.