Add Tick Count to Movie Files #508
Conversation
|
Idea LGTM, will let @lioncash continue to review the code. @dolphin-emu-bot rebuild |
|
Looks fine to me as well. |
|
@RisingFog Just squash the alignment, formatting etc commits into the main commit, and it should be good to go :) |
|
Two problems i see: You need to save current tick count to save state, otherwise if close dolphin and restart it g_tickCountAtLastInput will be 0, then if you load a save state, you will increase total tick count by much more than it should be. You also need to 0 out g_tickCountAtLastInput on shutdown/init, otherwise it will break if you stop recording, then start recording a new movie without closing dolphin. |
|
Also the way you've done this, g_currentTickCount is totally unecessary |
| @@ -834,6 +844,8 @@ void LoadInput(const std::string& filename) | |||
| g_totalFrames = tmpHeader.frameCount; | |||
| g_totalLagCount = tmpHeader.lagCount; | |||
| g_totalInputCount = tmpHeader.inputCount; | |||
| g_totalTickCount = tmpHeader.tickCount; | |||
| g_tickCountAtLastInput = tmpHeader.tickCount; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM |
|
@dolphin-emu-bot rebuild |
Added tick count to .dtm movie files for more accurate time calculations
|
And once more (although it'll likely pass as usual) @dolphin-emu-bot rebuild |
Add Tick Count to Movie Files
Added tick count to .dtm movie files for more accurate time calculations