Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an unused variable. #510

Merged
merged 1 commit into from Jun 25, 2014
Merged

Conversation

RachelBryk
Copy link
Member

It's never been used since it was added except to check the value, which is always false.

It's never been used since it was added except to check the value, which is always false.
@lioncash
Copy link
Member

I may be wrong here, but what I think was supposed to happen is within the if(!isscale) conditional, it was supposed to set isscale to true, but that's just me.

Can you run a git blame on it to see who introduced that code?

@RachelBryk
Copy link
Member Author

It was added here b7ecd016

@delroth
Copy link
Member

delroth commented Jun 19, 2014

@dapetcu21 You wouldn't happen to remember about this code? :)

On Thu, Jun 19, 2014 at 2:39 AM, RachelBryk notifications@github.com
wrote:

It was added here b7ecd01
b7ecd016


Reply to this email directly or view it on GitHub
#510 (comment).

Pierre "delroth" Bourdon delroth@gmail.com
Software Engineer @ Zürich, Switzerland
http://code.delroth.net/

@dapetcu21
Copy link
Contributor

I swear I don't know whatever I intended with that if. I think it's safe to remove.

lioncash added a commit that referenced this pull request Jun 25, 2014
Remove an unused variable.
@lioncash lioncash merged commit 2db5061 into dolphin-emu:master Jun 25, 2014
@RachelBryk RachelBryk deleted the unused branch July 6, 2014 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants