Ensure (Get|Set)ColumnWidth is not called on a non existant column. #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
Please change the commit message to include a short one-line summary at the top (put the description in the following lines). Also please use a short summary for the PR title, rather than stuffing the description into the title. This is relevant because both the PR title and the first line of a commit message (and only the first X characters of it) are printed in various git logging views (e.g. EDIT: Thanks. |
The AutomaticColumnWidth method can be called when the game list does not have any columns (for example when dolphin is starting). In this case wxWidgets assertions fail when (Get|Set)ColumnWidth are called on columns that do not exist. So check to make sure there are columns to prevent this.
glennricster
changed the title
|
LGTM, too. |
neobrain
added a commit
that referenced
this pull request
Jun 20, 2014
Ensure (Get|Set)ColumnWidth is not called on a non existant column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The AutomaticColumnWidth method can be called when the game list does not have any columns (for example when dolphin is starting). In this case wxWidgets assertions fail when (Get|Set)ColumnWidth are called on columns that do not exist. So check to make sure there are columns to prevent this.