Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the common "Failed to enumerate outputs" message much more useful. #520

Merged
merged 1 commit into from Jun 21, 2014

Conversation

pauldacheez
Copy link
Contributor

Now it includes its most common cause, a simply-worded solution, and an exclamation point. Grammar/wording nitpicks welcome.

I used tabs for consistency with the PanicAlerts in OpenGL's Render.cpp; if spaces are preferred, I'll fix it.

I also have no way to test if this compiles/works/looks good without a Windows installation or a laptop with switchable graphics, so tests from the buildbot and anyone with those two things would be nice.

@delroth
Copy link
Member

delroth commented Jun 20, 2014

@dolphin-emu-bot rebuild

Wrong alignment.
Newlines in a string are bad (are they even valid?). Use several single-lines strings with implicit concatenation instead.

@pauldacheez
Copy link
Contributor Author

I fixed that before I filed the PR, but I forgot to git add before amending/pushing. :P

@pauldacheez
Copy link
Contributor Author

Tabs converted to spaces.

@delroth
Copy link
Member

delroth commented Jun 20, 2014

@dolphin-emu-bot rebuild

1 similar comment
@neobrain
Copy link
Member

@dolphin-emu-bot rebuild

Now it includes its most common cause, a simply-worded solution, and an exclamation point.
@lioncash
Copy link
Member

And third time's the charm! @dolphin-emu-bot rebuild

neobrain added a commit that referenced this pull request Jun 21, 2014
Make the common "Failed to enumerate outputs" message much more useful.
@neobrain neobrain merged commit cad7614 into dolphin-emu:master Jun 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants