Fix crashes when dragging and dropping files outside of the gamelist #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,6 +54,7 @@ | |||
| #include "Core/CoreParameter.h" | |||
| #include "Core/Movie.h" | |||
| #include "Core/State.h" | |||
| #include "Core/HW/DVDInterface.h" | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Mostly LGTM. |
lioncash
added a commit
that referenced
this pull request
Jun 28, 2014
Fix crashes when dragging and dropping files outside of the gamelist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Prior to this PR dragging and dropping games into a docked window other than the game list would cause the emulator to initialize incorrectly and crash due to an access violation from dereferencing a null pointer (thanks to JMC for pointing this out). Since the idea here is to initialize the game/compatible file regardless of its dropped location within the main frame, it makes sense to actually have this handling code within the Frame code.
The game list is locked into the main frame, so this still retains the same behavior. It just won't crash when drag/drop is done on any other docked window in the main frame.