Fixed issue with DSP Dump not closing files.

[workhorsy]

When dumping the two DSP ROMs to file, if it failed to open one of them, neither will be closed. It should now close any that were opened.

[magumagu]

FYI, you can just force-push (git push -f) onto an existing branch, and that will automatically update the PR.

[workhorsy]

cool. I'll have to remember that for the future. I used push -f to re-upload the change, but I assumed that it would not connect the two because the hash would be different. Looks like git/github is smart enough to connect the two.

Thanks

[pauldacheez]

You're choosing an entire branch to merge, not just a single commit, so you can destroy and recreate commits any way you want and it'll still recognize what you're pushing to.

Also, this is basic info, but if you ever want to have more than one PR open for a project at a time, you'll need to make separate non-master branches (git branch fix-dspspy-bugs && git checkout fix-dspspy-bugs) and push those. Merges from user:master into upstream:master just seem kinda lazy anyway, IMO.

[lioncash]

@dolphin-emu-bot rebuild

Doing a build check, and then it should be good to merge.

[workhorsy]

Thanks for the tips @pauldacheez . I usually do work and playing around in a separate branch. I was so concerned with not breaking my first commit to Dolphin, that I forgot to put my changes in a separate branch.

It's so nice here with all the people trying to help each other. Usually people just ignore new contributors if they do something wrong/not quite right. Thanks.