New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCI Folder: correctly identify region of sysmenu #531
Conversation
| u32 CurrentGameId = 0; | ||
| if (strUniqueID.length() >= 4) | ||
| if (strUniqueID == "0000000100000002") |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Looks good to me. |
GCI Folder: correctly identify region of sysmenu
|
I am getting in various tmnt games using the gci folder the message that the card is full, see link below: |
|
I'm not able to reproduce in the GameCube Teenage Mutant Ninja Turtles game (GTFEA4) |
|
@JMC47 try: |
|
I don't have those games unfortunately. I'm guessing you're right about this; that's why this isn't enabled by default. It's probably with the original build though, not this one. |
|
Also another issue, in Lord of the rings the two towers if i make a second save or even just overwrite a previous one and restart i get an error message that 69-GLOP-LOTRTTGameData0.gci has the same internal name as 69-GLOP-LOTRTTGameData.gci and could not be loaded. |
|
I assume these work with a regular memory card? There is an ini setting that changes it to a smaller card, I'll need to get
|
|
Are you touching the gci goes directly in this description? Or just
|
|
By overwritting an existing save ingame it creates a new gci file that gives the error message above that it couldn't be loaded because they have the same internal name. |
|
we should track this on the issue tracker, for tmnt try adding the following to the gameini for two towers can you use the regular memorycard (move yours to somewhere safe) |
|
I hate to spam this more, but fifologs have a similar issue. Fifologs should not require memory cards to be loaded at all, but it does the whole sysmenu + pal glitch you fixed. |
|
Is any progress happening on getting the issue resolved? It surely enough looks fairly critical, hence I'd rather not have it living it master. |
|
The lotr issue should be an easy fix, I'll get a build up for testing
|
|
I believe all of the issues may be resolved by PR544, waiting for testing |
|
Thanks! I should probably correct myself by the way; I was under the impression this PR was introducing a regression, rather than the original WIP feature simply having still having a bug. Of course, I didn't intend a revert for this case. Either way, nice to see the issues resolved :) |
JMC47 identified that the wii system menu region was not correctly identified, this correctly identifies the region for the special case of the sysmenu,
gc/wii disc/wiiware/vc are all correctly identified by the original
homebrew will always use europe as is done everywhere else