Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCI Folder: correctly identify region of sysmenu #531

Merged
merged 1 commit into from Jun 25, 2014

Conversation

LPFaint99
Copy link
Contributor

JMC47 identified that the wii system menu region was not correctly identified, this correctly identifies the region for the special case of the sysmenu,
gc/wii disc/wiiware/vc are all correctly identified by the original
homebrew will always use europe as is done everywhere else

u32 CurrentGameId = 0;
if (strUniqueID.length() >= 4)
if (strUniqueID == "0000000100000002")

This comment was marked as off-topic.

This comment was marked as off-topic.

@lioncash
Copy link
Member

Looks good to me.

lioncash added a commit that referenced this pull request Jun 25, 2014
GCI Folder: correctly identify region of sysmenu
@lioncash lioncash merged commit eb3de73 into dolphin-emu:master Jun 25, 2014
@Linktothepast
Copy link
Contributor

I am getting in various tmnt games using the gci folder the message that the card is full, see link below:
http://prntscr.com/3xgqxq

@JMC47
Copy link
Contributor

JMC47 commented Jun 28, 2014

I'm not able to reproduce in the GameCube Teenage Mutant Ninja Turtles game (GTFEA4)

@Linktothepast
Copy link
Contributor

@JMC47 try:
TMNT:Mutant Melee GE5EA4
TMNT™2 BATTLE NEXUS™ GNIEA4
TMNT®3 MUTANT NIGHTMARE™ G3QEA4

@JMC47
Copy link
Contributor

JMC47 commented Jun 28, 2014

I don't have those games unfortunately. I'm guessing you're right about this; that's why this isn't enabled by default. It's probably with the original build though, not this one.

@Linktothepast
Copy link
Contributor

Also another issue, in Lord of the rings the two towers if i make a second save or even just overwrite a previous one and restart i get an error message that 69-GLOP-LOTRTTGameData0.gci has the same internal name as 69-GLOP-LOTRTTGameData.gci and could not be loaded.

@LPFaint99
Copy link
Contributor Author

I assume these work with a regular memory card?

There is an ini setting that changes it to a smaller card, I'll need to get
to a computer and look that up
On Jun 28, 2014 2:45 PM, "Linktothepast" notifications@github.com wrote:

@JMC47 https://github.com/JMC47 try:
TMNT:Mutant Melee GE5EA4
TMNT™2 BATTLE NEXUS™ GNIEA4
TMNT®3 MUTANT NIGHTMARE™ G3QEA4


Reply to this email directly or view it on GitHub
#531 (comment).

@LPFaint99
Copy link
Contributor Author

Are you touching the gci goes directly in this description? Or just
referring to in game overwriting?
On Jun 28, 2014 3:14 PM, "Linktothepast" notifications@github.com wrote:

Also another issue, in Lord of the rings the two towers if i make a second
save or even just overwrite a previous one and restart i get an error
message that 69-GLOP-LOTRTTGameData0.gci has the same internal name as
69-GLOP-LOTRTTGameData.gci and could not be loaded.


Reply to this email directly or view it on GitHub
#531 (comment).

@Linktothepast
Copy link
Contributor

By overwritting an existing save ingame it creates a new gci file that gives the error message above that it couldn't be loaded because they have the same internal name.

@LPFaint99
Copy link
Contributor Author

we should track this on the issue tracker, for tmnt try adding the following to the gameini
[Core]
MemoryCard251 = True
example
LPFaint99@c7faf2b

for two towers can you use the regular memorycard (move yours to somewhere safe)
save and overwrite/ whatever you are doing with gci folder, and send me the memcard,
if possible a copy of the memorycard after each save
I don't have the mentioned games, I suspect I can identify the issue with LOTR, but not really sure what is going on with tmnt

@JMC47
Copy link
Contributor

JMC47 commented Jun 29, 2014

I hate to spam this more, but fifologs have a similar issue. Fifologs should not require memory cards to be loaded at all, but it does the whole sysmenu + pal glitch you fixed.

@neobrain
Copy link
Member

Is any progress happening on getting the issue resolved? It surely enough looks fairly critical, hence I'd rather not have it living it master.

@LPFaint99
Copy link
Contributor Author

The lotr issue should be an easy fix, I'll get a build up for testing
tonight
Not sure about tmnt, I'll try and figure it out tonight but hard to say
what is happening.
On Jun 30, 2014 12:35 PM, "Tony Wasserka" notifications@github.com wrote:

Is any progress happening on getting the issue resolved? It surely enough
looks fairly critical, hence I'd rather not have it living it master.


Reply to this email directly or view it on GitHub
#531 (comment).

@LPFaint99
Copy link
Contributor Author

I believe all of the issues may be resolved by PR544, waiting for testing

@neobrain
Copy link
Member

neobrain commented Jul 1, 2014

Thanks! I should probably correct myself by the way; I was under the impression this PR was introducing a regression, rather than the original WIP feature simply having still having a bug. Of course, I didn't intend a revert for this case.

Either way, nice to see the issues resolved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants