Add Change Disc option to the right-click menu in the game list. #532
Conversation
|
Can someone build this so me and JMC can test this? |
|
@dolphin-emu-bot rebuild |
|
@zhuowei Can you rebase this so it can be merged in the future after testing? |
|
This works for GC games (Metal Gear Solid: Twin Snakes) and Wii games (System Menu switching) without issues for me, it's just a lot faster. Thank you for actually taking the time to implement it! |
|
Rebased. |
|
@dolphin-emu-bot rebuild |
|
You're going to need to reinclude DVDInterface, since it was removed in a recent commit. (Reinclude it alphabetically though or you'll trip the lint builder). |
|
Yea... this let's you select things that aren't discs. Hitting "change disc" on a virtual console game brings a "Unable to read the disc" error in the disc channel. This isn't exactly the fault of this PR however - doing change disc from the menu allows you to use change disc on anything as well. So it's a preexisting problem. Someone needs to fix it though, especially since this PR improves discoverability. Other than that, this works great. |
|
I don't think that should block this from being merged though, it's a pre-existing flaw, and if you insert garbage into the Wii it says the same thing. |
|
@MaJoRoesch I can try to make this only show for discs. |
|
It would be best to just fix Change Disc... This is a preexisting problem after all. |
|
What do you limit it to, though? WBFS, ISO, CISO, GCM? |
|
This can also be fixed in a new pull request too if need be. This is simply a GUI PR |
|
I agree with Lioncash. I (the non-coder) say we can just merge this and fix Change Disc in another PR. |
|
Re-rebased; fixed the missing header error, change disc now only shows up for GameCube and Wii discs in the right click menu. |
| @@ -903,6 +905,11 @@ void CGameListCtrl::OnRightClick(wxMouseEvent& event) | |||
| { | |||
| popupMenu->Append(IDM_LIST_INSTALLWAD, _("Install to Wii Menu")); | |||
| } | |||
| if (selected_iso->GetPlatform() == GameListItem::GAMECUBE_DISC || | |||
| selected_iso->GetPlatform() == GameListItem::WII_DISC) { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Everything is functionally good. Once the code passes, I think it's ready. Thanks for the work on making changing discs much simpler! |
|
@lioncash brace placement fixed. |
Add Change Disc option to the right-click menu in the game list.
For issue 7411.
I didn't test this thoroughly since I don't have any game that needs this option, but changing to the active game's disc doesn't do anything, just like the change disc option in the file menu, so I think this works.