Centralize some common banner loader class members. #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erLoader These are both used within the banner loaders, and IsValid is exactly the same. So this makes sense.
|
LGTM, feel free to merge when the buildbot gives its OK. |
lioncash
added a commit
that referenced
this pull request
Jun 29, 2014
Centralize some common banner loader class members.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Centralizes common elements that are used the same way into the base class (
IBannerLoader)Specifically it moves m_IsValid, IsValid() and m_pBannerFile into
IBannerLoader