Remove weird buffering from WII_IPC_HLE_Device_sdio_slot0.cpp

[Parlane]

No description provided.

[BhaaLseN]

Why was it there in first place?

[magumagu]

The difference between the old code and the new code is that the new code can crash Dolphin... granted, our memory code is a mess, but this isn't a step in the right direction.

[magcius]

How can the new code crash?

[magumagu]

Memory::GetPointer can return null.

[magcius]

Would that ever happen in any case that also wouldn't crash the Wii?

[delroth]

Also, with Memory::Read8 as currently done, IPC_HLE can trigger a DSI,
which is probably even more wrong than crashing Dolphin.

On Mon, Jun 30, 2014 at 9:44 PM, Jasper St. Pierre <notifications@github.com

wrote:

Would that ever happen in any case that also wouldn't crash the Wii?

—
Reply to this email directly or view it on GitHub
#542 (comment).

Pierre "delroth" Bourdon delroth@gmail.com
Software Engineer @ Zürich, Switzerland
http://code.delroth.net/

[magumagu]

It wouldn't happen normally. I'm not completely sure how a Wii would react..

[delroth]

IPC request would return an error. IOS usually checks where the data comes
from before reading it (equivalent of copy_from_user in the Linux kernel).
"usually" being the keyword, since IOS is not really secure or consistent
in what it does.

On Mon, Jun 30, 2014 at 9:51 PM, magumagu notifications@github.com wrote:

It wouldn't happen normally. I'm not completely sure how a Wii would
react..

—
Reply to this email directly or view it on GitHub
#542 (comment).

Pierre "delroth" Bourdon delroth@gmail.com
Software Engineer @ Zürich, Switzerland
http://code.delroth.net/

[delroth]

Since the old code was just as wrong as the new one on top of being slow, I don't think the use of GetPointer should block this PR.