Changed lingering header include guards to pragma once. #546
+4
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some headers where using #ifndef to guard being including multiple times. But most were using pragma once. So for consistency I changed them all to use pragma once.
|
LGTM |
|
@dolphin-emu-bot rebuild |
|
Do users need to be in a special group or something, to tell dolphin-emu-bot to do a rebuild? |
|
Yes, this is because anyone could submit malware in a PR and get our build On Wed, Jul 2, 2014 at 10:30 AM, Matt Jones notifications@github.com
Pierre "delroth" Bourdon delroth@gmail.com |
|
LGTM |
neobrain
added a commit
that referenced
this pull request
Jul 6, 2014
Changed lingering header include guards to pragma once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some headers where using #ifndef to guard being including multiple times. But most were using pragma once. So for consistency I changed them all to use pragma once.